Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(design): adjustments for Nextcloud 30 - v3 #12810

Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix(design): adjustments for Nextcloud 30 - v3 #12810

merged 5 commits into from
Jul 29, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 25, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image
image image

🚧 Tasks

Conversation and composing

  • Top bar title is cut off - dropped for now
  • Date marker "Today, July 23, 2024" border radius should be reduced to make it similar to the button

List view

  • Margin on the left of list item is too much and on the right is too little --> it should nicely aligned with the left of the search bar and right aligned with the new conversation button (upstream issue?)

Sidebar

  • Media tab: thumbnails are top left aligned their containers

Calling

  • Media settings:
    • border radius on bg should be consistent
    • "Test devices" button should be left aligned with select components

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy self-assigned this Jul 25, 2024
@Antreesy Antreesy requested a review from ShGKme July 25, 2024 10:10
@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jul 25, 2024
@Antreesy Antreesy marked this pull request as ready for review July 25, 2024 10:11
@ShGKme

This comment was marked as resolved.

Sign in to view
@ShGKme ShGKme mentioned this pull request Jul 25, 2024
Open
23 tasks
ShGKme
ShGKme reviewed Jul 25, 2024
View reviewed changes
src/components/TopBar/TopBar.vue Outdated
@@ -347,6 +347,7 @@ export default {
width: 100%;
overflow: hidden;
min-height: var(--default-clickable-area);
font-size: 13px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the text smaller than default even when there is only a title without a description.
And there is some additional space if we reduce the padding.

@jancborchardt What do you think is better here?

Also, we can stop showing the description here and show it in the sidebar. It is one line for a long (potentially rich) text anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes, will provide this suggestion as a separate PR

@Antreesy Antreesy requested a review from ShGKme July 29, 2024 13:30
ShGKme
ShGKme approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good everywhere, fixes all the issues

@Antreesy Antreesy merged commit eb0c39a into main Jul 29, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/design-adjust-v3 branch July 29, 2024 14:50
@Antreesy Antreesy mentioned this pull request Jul 29, 2024
Closed
6 tasks
@nickvergessen nickvergessen mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review design feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @danxuliu